Discord RPC

[dubfib]

I notice your lacking Discord RPC support so I decided why not add it I know the icon isn't the best but atleast it works for now

[dubfib]

Already been tested btw

[dubfib]

this is on PC on mobile is screwed up

[hmlendea]

Is there a way to change the title to GeForce NOW (capital F). It looks a bit weird with a lowercase F because right below it it's written in uppercase, and thus is inconsistent.

[hmlendea]

Other than that it looks great and thank you very much for the contribution!

[dubfib]

Is there a way to change the title to GeForce NOW (capital F). It looks a bit weird with a lowercase F because right below it it's written in uppercase, and thus is inconsistent.

Hmm so the thing is that it might take a bit of time because I need to do something with arguments I realized what you wanted me to do and its fixed

[dubfib]

I did everything you said also I might add a bit more in a later poll request, not this one.

[hmlendea]

Looks ok.

I can merge it now if you want.

[hmlendea]

Also, a neat idea for a future PR: a toggle to disable this functionality, in case someone does not want it for any reason. (e.g. a CLI argument like --disale-discord-rpc, or a config file)

[dubfib]

Also, a neat idea for a future PR: a toggle to disable this functionality, in case someone does not want it for any reason. (e.g. a CLI argument like --disale-discord-rpc, or a config file)

I dont know how to do that actually with a command but I can make like a settings.json file

[dubfib]

Looks ok.

I can merge it now if you want.

If you want sure but this is only version 1.

[hmlendea]

Looks ok. I can merge it now if you want.

If you want sure but this is only version 1.

As long as it works it's fine. It can always be further refined later. But if you plan to do more changes in this PR go ahead, I'm not in a hurry :P

Also, a neat idea for a future PR: a toggle to disable this functionality, in case someone does not want it for any reason. (e.g. a CLI argument like --disale-discord-rpc, or a config file)

I dont know how to do that actually with a command but I can make like a settings.json file

That would be nice. Probably even better than the CLI argument. Just make sure to read the file from a location within the home directory, preferably ~/.config/GeForce NOW since that directory already exists for this app's cache and electron-specific configs

[dubfib]

Looks ok. I can merge it now if you want.

If you want sure but this is only version 1.

As long as it works it's fine. It can always be further refined later. But if you plan to do more changes in this PR go ahead, I'm not in a hurry :P

Also, a neat idea for a future PR: a toggle to disable this functionality, in case someone does not want it for any reason. (e.g. a CLI argument like --disale-discord-rpc, or a config file)

I dont know how to do that actually with a command but I can make like a settings.json file

That would be nice. Probably even better than the CLI argument. Just make sure to read the file from a location within the home directory, preferably ~/.config/GeForce NOW since that directory already exists for this app's cache and electron-specific configs

I am doing a CLI argument for this actually

[dubfib]

^^^ when on the home screen/not have a game loaded

^^^ when in a game

to disable RPC in the startup add --disable-rpc

[dubfib]

The "Not affiliated with NVIDIA" is so then you don't get sued not that sure but just good to have

[dubfib]

I already committed and should be ready you can merge now because I don't think I'm going to add more unless I can think... if that happens I'll make another pull request