search

hmlendea / gfn-electron

Linux Desktop client for Nvidia's GeForce NOW game streaming service
GNU General Public License v3.0
510 stars 62 forks source link

Esc fix #15

Closed eranok closed 3 years ago

eranok commented 3 years ago

Quick esc fix. Now to go off fullscrean press SHIFT+`

hmlendea commented 3 years ago

I'm going to try this out as soon as I can. Thanks for the contribution!!!

hmlendea commented 3 years ago

Ok so I've tested it and it seems to work for the most part.

There is a situation where it doesn't, though. If you exit fullscreen (shift+`) and the GFN popup about going back into the game appears, if you click on the button to go into the game, it goes back to fullscreen. However, if you do that, the next time you press ESC it will both activate whatever esc is bound to in the game, as well as exiting fullscreen again (and funnily enough this time a popup is not displayed and it actually allows you to play the game windowed, lol)

I'm suggesting to merge this as-is for now, since this is a pretty big issue that's been bugging us for a long time, and the fix is definetely good enough. This is an edge case and nothing game-breaking, just a minor annoyance. I'd merge this now and investigate/fix this smaller issue afterwards, instead of delaying the whole fix any longer.

What do you think?

eranok commented 3 years ago

I am good with it :) You can merge whenever you want (~˘▾˘)~ That was pretty annoying bug, so i went to fix that right away when found this project for linux)) Best wishes, Peace)