hmlendea / gfn-electron

Linux Desktop client for Nvidia's GeForce NOW game streaming service
GNU General Public License v3.0
488 stars 61 forks source link

Updated to `electron` 18.3.2 #151

Closed hmlendea closed 2 years ago

xor-128 commented 2 years ago

I used specific version of fetch for bypassing some errors. If you change the fetch version, You no longer create desktop shortcuts... Or just fix the node-fetch issue which is just changing require to import.

xor-128 commented 2 years ago

Or nvm :D

hmlendea commented 2 years ago

There was a high severity vulnerability in the old version of node-fetch, this is why I updated.

However, I tested it and, at least on my system, creating the launchers using Control + Shift + P still works.

xor-128 commented 2 years ago

By the way, you cant add desktop shortcut to steam with arguments and icon. Its just gets the icon of electron and ignores the parameter. At least thats the behaviour at Windows.