search

hmlendea / gfn-electron

Linux Desktop client for Nvidia's GeForce NOW game streaming service
GNU General Public License v3.0
531 stars 64 forks source link

Remove the ChromeOS User Agent #17

Closed hmlendea closed 3 years ago

hmlendea commented 4 years ago

Some time ago a GamingOnLinux article reported that GFN works well with Linux without spoofing the User Agent string to a ChromeOS one. Since then that continued to be the case and it seems like the spoofed UA is not necessary anymore.

If all goes well, it should be removed in the next version.

Siedhuss commented 3 years ago

for information other user agent strings could result in no choice of keyboard loayout inside gfn

TheRealFanjin commented 3 years ago

I'm on Linux and having no user agent switcher just said that my device was unsupported

hmlendea commented 3 years ago

I'm on Linux and having no user agent switcher just said that my device was unsupported

Huh, interesting. What browser did you use?

TheRealFanjin commented 3 years ago

Both Chrome and Edge and maybe Firefox too

tosziro commented 3 years ago

I can confirm that GeForce Now works correct with Brave and Chromium browser without any workarounds. We dont need this ChromeOS user agent any more.

hmlendea commented 3 years ago 
Soon we’ll bring that experience to more Chrome platforms, including Linux*, PC, Mac and Android. Stay tuned for updates as we approach a full launch early next year.

From my understanding it's not working for everyone still, as that is yet to happen next year. For some it has been working for a while (it did for me since before I made this PR), but it's not yet safe to remove it for the masses.

Once the official announcement is made from Nvidia, I will merge this PR

hmlendea commented 3 years ago

Merged in #36