Bump Electron & Electron Builder to latest stable versions

hmlendea / gfn-electron

Linux Desktop client for Nvidia's GeForce NOW game streaming service

GNU General Public License v3.0

531 stars 64 forks source link

Bump Electron & Electron Builder to latest stable versions #24

Closed kaizoho closed 3 years ago

kaizoho commented 3 years ago

This is a pretty simple PR that:

Bumps Electron to 11.0.2 and Electron Builder to 22.9.1.
Removes the package-lock.json file as it is unnecessary and should be generated by npm on the user's machine.
Adds package-lock.json to the .gitignore file.

If you dislike the removal of package-lock.json I will happily revert.

I've noticed nothing broken from my testing, though further testing by others is appreciated.

D3SOX commented 3 years ago

I don't think you should remove the package-lock.json. It is intended to be committed. It guarantees that when someone clones the repo and does a npm install they always get the same versions.

hmlendea commented 3 years ago

I don't have a strict preference, but I was following the standard conventions from electron/electron-quick-start which has the package-lock.json unignored. So I think I'd rather keep it even if it's just to ensure consistency with it.

kaizoho commented 3 years ago

I have restored and updated package-lock.json. I've also removed it from the .gitignore. Building works well on Ubuntu 20.04.1 (amd64) with the latest stable version of NodeJS 14. There are no apparent issues when running the program.

hmlendea commented 3 years ago

I am going to merge this once you confirm there are no further changes coming