search

hmlendea / gfn-electron

Linux Desktop client for Nvidia's GeForce NOW game streaming service
GNU General Public License v3.0
488 stars 61 forks source link

[BUG] Esc key not working outside the app #241

Closed andro404-MC closed 3 weeks ago

andro404-MC commented 1 month ago

Describe the bug

When the app is launched the Esc key is not usable outside it which is frustrating especially since I tend to use Neovim for code editing when looking for the next available rig and I can't get to the NORMAL mode if there's a way to set an "only when on focused" key, please consider using it instead of the current implementation .

To Reproduce

  1. launch the app
  2. switch to another app
  3. Esc key not working

Screenshots

No response

Operating System

archlinux

Desktop Environment

bspwm

Display Server

x11

Installation method

flatpak

Version

2.1.0

Is this a fresh install of the app or an update from a past version?

fresh install

Did this issue appear right away upon installation/updating, or spontaneously?

right after installation

Additional context

No response

andro404-MC commented 1 month ago

[UPDATE] all the ones defined with globalShortcut.register() are global and have this issue I found this npm package called electron-localshortcut that works exactly like globalShortcut and without using a Menu. I will be sending a pr soon after testing

andro404-MC commented 1 month ago

PR #242

andro404-MC commented 3 weeks ago

Merged #242