hmlendea / gfn-electron

Linux Desktop client for Nvidia's GeForce NOW game streaming service
GNU General Public License v3.0
500 stars 62 forks source link

Google Account login fails due to unsecure browser #50

Closed ResonantFilter closed 3 years ago

ResonantFilter commented 3 years ago

I begin by thanking all the contributors that work on this project. I wanted to point out that if the geforce now account is a Google account linked to the service, the login will fail due to the fact that Google considers the browser opened by the application as unsecure.

Thanks again for your work.

D3SOX commented 3 years ago

Duplicate of #49

hmlendea commented 3 years ago

Yes, Google does indeed consider all Electron apps as "unsecure browsers".

I will allocate some time to study the ToS more and see if there is any way I can make the GAuth work without breaking the ToS. There certainly are ways to make it work (some Electron apps do it successfully), but I want to make sure it's ok and safe for the end-users

EDIT: However, I also want to be transparent and say that this is not a high priority at the moment.

ResonantFilter commented 3 years ago

Thanks i did not see issue #49, I understand that would be a secondary feature. Thanks a lot anyways!

D3SOX commented 3 years ago

@hmlendea I think a possible workaround would be to somehow do the login in the user's default browser and redirect them back to the application once they're logged in. Not entirely sure how I would implement that though