hmlendea / gfn-electron

Linux Desktop client for Nvidia's GeForce NOW game streaming service
GNU General Public License v3.0
500 stars 62 forks source link

Problem with fullscreen #56

Closed NicoRoumeau closed 3 years ago

NicoRoumeau commented 3 years ago

Hello, this is my first post in Github so very sorry if I make mistakes!

I installed geforce-electron on Fedora 34 via flathub.

The problem is that when I launch a game, Geforce propose me to enter in full screen by clicking "continue" (your server is ready - enter in fullscreen mode - continue), the full screen appears (behind), but the proposal remains. If I hit ESC, the proposal disapears but I'm not anymore in full screen. Am I clear? ;)

I made some screenshots.

Capture d’écran du 2021-05-08 15-07-46

Capture d’écran du 2021-05-08 15-08-20

Capture d’écran du 2021-05-08 15-08-42

Thank you very much for this port.

hmlendea commented 3 years ago

Hello,

Please provide the following info:

NicoRoumeau commented 3 years ago

Hello, thank you for your answer.

I'm on Fedora 34 (fresh install). I install gfn-electron via Flathub website. It's the 1.0.8 version.

mburakov commented 3 years ago

The ESC behavior might be related to #53.

@NicoRoumeau, are you on Gnome Wayland session by any chance? Try switching to Gnome Xorg session, this might help.

NicoRoumeau commented 3 years ago

Thank you for your answer.

Yes I'm on Wayland. But I just opened an Xorg session and I got the same issue. In fact, GFN at the start is windowed, i select my game (play) and then a popup tells me that I've got to enter in Full Screen Mode, with a button "CONTINUE". When I click on this button, the full screen mode appears behind but the window telling me that I need to enter in full screen mode with the Continue button remains. And the only way to get disappear this window is to hit the ESC key, but I'm not anymore in full screen mode doing that!

hmlendea commented 3 years ago

The flatpak version is quite outdated. The latest release is 1.1.2. Could you try downloading the latest version manually from the releases (the zip version for example) and running it from there and see if it works fine?

Also, Super(WinKey)+F should toggle between windowed and fullscreen, which could serve as a temporary "fix".

NicoRoumeau commented 3 years ago

Ok, thank you for your answer. I try the AppImage version of the 1.1.2, I have the same problem, the "Full Screen Proposition Window" does not disappear when I click on "Continue" but with your solution Super+F two times, it is ok!

Do you plan to release a Flat version of the 1.1.2?

Thank you again!

hmlendea commented 3 years ago

It is very weird that the issue still persists for you even with the latest version.

Is there any GNOME setting that you changed which you think could have interfered with the window arangements/tiling/focusing? Or an extension, maybe?

I also use GNOME but it's using X.org and it's on Arch - so it's not quite the same thing, but it works ok for me.

I'm trying to figure out what's going wrong for you but I'm a bit stuck :P The WinKey+F fix is thankfully a valid workaround for you, but it's surely annoying and definitely not ok to have to do that every time.

By the way, does pressing ESC also exit fullscreen for you? (using the AppImage)

Regarding flat: I would, but I'm not really able to invest time into it and I have no prior knowledge to rely on :( I have opened an issue (#59) asking for volunteers, and hopefully someone will take it.

hmlendea commented 3 years ago

Update: I've managed to figure out how to fix and update the Flatpak build myself. It's now using the latest version, yay! I've also added a FlatHub installation button for it in the readme

NicoRoumeau commented 3 years ago

Thank you very much!!!

nsrosenqvist commented 3 years ago

I'm using the flathub flatpak as well and am also experiencing this issue (on X.org). What I had to do to solve it was to bind a keyboard shortcut to "toggle fullscren mode" in gnome-control-center, and when pressing it fullscreen is toggled off and the message disappears, then I'm able to toggle fullscreen back on again using the same keyboard shortcut. Maybe bind f11 for this to mimic the behavior for browsers so that a custom keyboard shortcut isn't required for those experiencing the issue?

hmlendea commented 3 years ago

I'm using the flathub flatpak as well and am also experiencing this issue (on X.org). What I had to do to solve it was to bind a keyboard shortcut to "toggle fullscren mode" in gnome-control-center, and when pressing it fullscreen is toggled off and the message disappears, then I'm able to toggle fullscreen back on again using the same keyboard shortcut. Maybe bind f11 for this to mimic the behavior for browsers so that a custom keyboard shortcut isn't required for those experiencing the issue?

There's already a Super(WinKey)+F shortcut for toggling fullscreen, or is that not working in your case?

vampywiz17 commented 3 years ago

Same problem, Fedora 34, Flatpak install, GNOME/x11

Draecal commented 2 years ago

Same issue