search

hmlendea / more-cultural-names

Mod for various strategy games, that dynamically changes the province names based on the ruler's culture
https://hmlendea.github.io/more-cultural-names/workshop
GNU General Public License v3.0
19 stars 8 forks source link

Enhancing baronies Arabic names under e_hispania #405

Closed stervel closed 11 months ago

stervel commented 12 months ago

Still a halfway. I'll get the Spanish k titles later.

stervel commented 12 months ago

Can you please help me understand the mistake? I was trying to make separate names for k_valencia by making a new location entity with fallback to original entity.

hmlendea commented 12 months ago

https://github.com/hmlendea/more-cultural-names/actions/runs/7080754763/job/19269079450

The first error indicates an incorrect sort order (wrong location has a minus '-' sign, and the correct location has a plus '+' sign)

The second error indicates that the specified game IDs are present in multiple (in this case 2) locations simultaneously.

stervel commented 12 months ago

Ah nice, thanks! Pushing the fix now.

hmlendea commented 12 months ago

You're welcome.

So, valencia_kingdom location should be after valencia_gulf and before valenciennes. (Basically, all locations should be sorted alphabetically based on their IDs)

And, the GameIds k_valencia should only appear in one location at a time, so e.g. keep them in valencia_kingdom but remove them from valencia.

I will in the future work on a completely new tool for validating the data, and I will make sure to have clear messages there. Right now it's not at all clear nor intuitive. If there's any other thing I can help with just let me know.

hmlendea commented 11 months ago

Is this ready to merge? Let me know when I should merge it.

stervel commented 11 months ago

Yes, you can merge it, btw. Upcoming changes will be added as the mods go by.