search

hmlongco / Factory

A new approach to Container-Based Dependency Injection for Swift and SwiftUI.
MIT License
1.83k stars 115 forks source link

Cleanup minimum requirements for Apple Platforms #130

Closed o-nnerb closed 1 year ago

o-nnerb commented 1 year ago

Since Factory doesn't use any code that is restricted to iOS, macOS, tvOS and watchOS versions, there's no need to specify the base versions. This will make Factory available for all platforms.

Also I removed the LinuxMain which is not required anymore since Swift 5.4

The last updates I've made was in the .podspec that contains some statements that aren't required.

hmlongco commented 1 year ago

The podspec change may or may not work as I believe I had to add those to get the cocoapods submission process to work correctly.

o-nnerb commented 1 year ago

No problem, I'll undo the changes at podspec. I haven’t used cocoapods for some time now, so I'm not sure about my contribution on this file.

I'll follow what you've said.

hmlongco commented 1 year ago

The podspec source files and swift version can be changed...

s.source_files = "Sources/*/.swift" s.swift_version = '5.7'

But the rest of it was arrived at after some fairly frustrating back and forth with cocoapods. I think it needs to remain unchanged.