search

hmlongco / Factory

A new approach to Container-Based Dependency Injection for Swift and SwiftUI.
MIT License
1.83k stars 115 forks source link

Changes to have a successful build while creating xcframework #174

Closed CEDENOGLOBANT closed 6 months ago

CEDENOGLOBANT commented 9 months ago

Hello this few changes makes possible to have a successful build while creating a xcframework when BUILD_LIBRARY_FOR_DISTRIBUTION is set to YES

Here is a link to the issue

https://github.com/hmlongco/Factory/issues/173

hmlongco commented 9 months ago

Probably need to just do a plain initializer. Makes no sense to make it inlineable only to call a second initializer. That should also avoid the need to do the funky settings setup.

CEDENOGLOBANT commented 8 months ago

Probably need to just do a plain initializer. Makes no sense to make it inlineable only to call a second initializer. That should also avoid the need to do the funky settings setup.

Removing the second init, just have one plain init, however the SwiftVerifyEmittedModuleInterface, still fails, here is an example of one of the errors

error: 'ManagedContainer' is not a member type of generic struct 'Factory.Factory' extension Factory.ManagedContainer

Working on fix it without using the settings on the Package.swift

hmlongco commented 6 months ago

Believe the changes to key in 2.3.2 fixed this issue.