search

hmlongco / Resolver

Swift Ultralight Dependency Injection / Service Locator framework
MIT License
2.15k stars 190 forks source link

Ability to resolve multiple implementations of same type #154

Open kmaschke85 opened 2 years ago

kmaschke85 commented 2 years ago

This PR adds the ability to resolve all registered implementations for a given type, where the implementations are differentiated by names. Please let me know what I can optimize.

hmlongco commented 2 years ago

So the first question is why? I'm not sure of the use case or what problem this will solve.

Secondarily, if you're nesting containers for mocking or modularization, then the current code only gets the first set of items it finds. It doesn't get "all" of them.

kmaschke85 commented 2 years ago

Valid question!

To your first one: being able to resolve multiple instances of the same registered type is something I am used to when working with .Net. Microsofts Dependency Injection framework and Autofac provide options for that. In my specific case I have multiple classes acting as handlers for some task and all of them need to perform their task. Makes it simple using DI for it so I can easily add new handlers.

Good catch on the nested containers, will look into that.

kmaschke85 commented 2 years ago

@hmlongco I addressed your feedback about the nested containers. Can you please review?

hmlongco commented 2 years ago

Went through this again and found that it still suffers from a bug when handling multiple containers.

Functionally this mechanism gathers up all of the named containers and stuffs them into an array so you can call them as needed. Right?

So what happens if container B is a child of container A... and container A has a named registration of "Fred" that was supposed to override the Fred in container B? In the current implementation both Freds will be gathered, returned and executed... and I don't think that's the desired result.

kmaschke85 commented 2 years ago

Didn't consider that. Made some additions and adjustments. @hmlongco

hmlongco commented 2 years ago

Terribly sorry for the delay. Been working on getting Factory, my latest DI system, out the door.

I'll put this in if you still want it, but one more change is needed; Throwing a fatal error if nothing is found doesn't make sense. Just return an empty array.

kmaschke85 commented 2 years ago

Addressed your PR review comments @hmlongco

Sorry for my delay this time (was on PTO).

kostisJP commented 2 years ago

Hello, we need that too! @hmlongco did you have time to review the PR?

majie776 commented 2 years ago

这是来自QQ邮箱的自动回复邮件。   邮件已收到

rahimlis commented 1 year ago

any update on this? @grinloc @hmlongco