search

hmol / LinkCrawler

Find broken links in webpage
MIT License
117 stars 59 forks source link

#25 Local links #26

Open dokkillo opened 7 years ago

dokkillo commented 7 years ago

I created a commit for use local url like home.

tdwright commented 7 years ago

Hi @dokkillo

Thanks for the PR.

It's a good idea, but I'm a bit worried that you may have opened the gates too far (i.e. some URLs that aren't valid will now parse correctly). That said, I can't think of a better way to do it.

Perhaps you could make this a configurable setting defaulting to disabled? That way users would be able to choose how they'd prefer these links to be handled.

Tom