local links shown as missing

hmol / LinkCrawler

Find broken links in webpage

MIT License

117 stars 59 forks source link

local links shown as missing #31

Open firecodergithub opened 7 years ago

firecodergithub commented 7 years ago

Don't know if this is a bug or a feature, but should local links be shown with status 0? e.g. links that are missing the base url (/page.html)? I assume they're also not crawled afterwards

firecodergithub commented 7 years ago

actually, been running now the unit tests and 2 of the 28 are failing, specifically this one with relative paths and the one with missing http( Parse_UrlOnlyRelativePath_True and Parse_UrlNoScheme_True). I'm running this from Visual Studio on Mac and running with Mono (which otherwise seems to work ok)

firecodergithub commented 7 years ago

Raise pull request #33 for this

tdwright commented 6 years ago

Hi @firecodergithub. I'll review this ASAP. Sorry about the delay!