hmpf commented 3 years ago

This adds user impersonation with django-su. Unfortunately we need a feature that django-su doesn't have yet (different actions on impersonated login vs logout) so the code is stashed away here for the time being.

codecov[bot] commented 3 years ago

Codecov Report

Merging #141 (4241885) into master (89821b7) will increase coverage by 5.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
+ Coverage   56.01%   61.03%   +5.01%     
==========================================
  Files          87      110      +23     
  Lines        6218     6721     +503     
==========================================
+ Hits         3483     4102     +619     
+ Misses       2735     2619     -116

Impacted Files	Coverage Δ
src/easydmp/site/urls.py	`70.58% <ø> (ø)`
src/easydmp/auth/admin.py	`100.00% <100.00%> (ø)`
src/easydmp/site/settings/base.py	`92.64% <100.00%> (+2.48%)`	:arrow_up:
src/easydmp/eestore/models.py	`53.00% <0.00%> (-4.55%)`	:arrow_down:
src/easydmp/dmpt/models.py	`52.93% <0.00%> (-4.48%)`	:arrow_down:
src/easydmp/plan/models.py	`42.58% <0.00%> (-3.76%)`	:arrow_down:
src/easydmp/dmpt/api/v2/serializers.py	`86.95% <0.00%> (-1.51%)`	:arrow_down:
src/easydmp/plan/views/__init__.py	`32.64% <0.00%> (-0.27%)`	:arrow_down:
src/easydmp/eventlog/models.py	`81.20% <0.00%> (-0.13%)`	:arrow_down:
src/easydmp/plan/urls.py	`100.00% <0.00%> (ø)`
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 89821b7...9cbf0aa. Read the comment docs.

hmpf commented 3 years ago

The 3rd party library doesn't quite do what we need it to do.

hmpf / easydmp

Add support for user impersonation, via admin #141

Codecov Report