hmpf / easydmp

MIT License
7 stars 2 forks source link

Read logging config from separate file #156

Closed hmpf closed 3 years ago

hmpf commented 3 years ago

This incidentally solves a problem on Django 3.1 triggered by running logging.config.dictConfig multiple times or logging something before logging is set up.

codecov[bot] commented 3 years ago

Codecov Report

Merging #156 into master will decrease coverage by 0.10%. The diff coverage is 51.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
- Coverage   61.07%   60.96%   -0.11%     
==========================================
  Files         112      113       +1     
  Lines        6728     6753      +25     
==========================================
+ Hits         4109     4117       +8     
- Misses       2619     2636      +17     
Impacted Files Coverage Δ
src/easydmp/site/settings/__init__.py 48.38% <48.38%> (ø)
src/easydmp/site/settings/base.py 90.16% <75.00%> (-2.38%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ec55866...a2e2ee7. Read the comment docs.

vbhavdal commented 3 years ago

Here a "why" in the commit message would be OK, it is about Django 3.1 I understand.

hmpf commented 3 years ago

Here a "why" in the commit message would be OK, it is about Django 3.1 I understand.

Force-pushed an updated commit-message.

vbhavdal commented 3 years ago

You could also just update the title of the PR and use squash merge.