hmpf / easydmp

MIT License
7 stars 2 forks source link

Fix migration hooking up Answers with AnswerSets #161

Closed hmpf closed 3 years ago

hmpf commented 3 years ago

The existing migration did not take into account templates with more than one Section.

Good thing we caught this before a release.

codecov[bot] commented 3 years ago

Codecov Report

Merging #161 (e553c42) into master (191648a) will not change coverage. The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #161   +/-   ##
=======================================
  Coverage   55.17%   55.17%           
=======================================
  Files          97       97           
  Lines        5870     5870           
=======================================
  Hits         3239     3239           
  Misses       2631     2631           
Impacted Files Coverage Δ
...p/plan/migrations/0006_link_answer_to_answerset.py 60.00% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 191648a...e553c42. Read the comment docs.

hmpf commented 3 years ago

We should not forget to improve upon the devfixtures so we don't walk into this trap again. #162.

hmpf commented 3 years ago

We should probably also have migration tests =) now where was that link...