hmpf commented 3 years ago

NullBooleanField will be deprecated in favor of BooleanField(null=True) in Django 4.0, and Django 3.1 complains about them. The flip works on Django 2.2 as well so we do the flip now.

We're planning to squash migrations soon anyway, so it is handy to do this now.

codecov[bot] commented 3 years ago

Codecov Report

Merging #163 (d394d83) into master (25d9c74) will increase coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
+ Coverage   55.17%   55.20%   +0.03%     
==========================================
  Files          97       98       +1     
  Lines        5870     5874       +4     
==========================================
+ Hits         3239     3243       +4     
  Misses       2631     2631

Impacted Files	Coverage Δ
...plan/migrations/0008_modernize_NullBooleanField.py	`100.00% <100.00%> (ø)`
src/easydmp/plan/models.py	`42.70% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 25d9c74...d394d83. Read the comment docs.

hmpf commented 3 years ago

Merged manually after fixing the dependencies of the migration, since it also has a Plan-migration, like the previous PR.

hmpf / easydmp

Change NullBooleanField to BooleanField(null=True) #163

Codecov Report