codecov[bot] commented 3 years ago

Codecov Report

Merging #164 (07d9733) into master (25d9c74) will increase coverage by 0.86%. The diff coverage is 52.38%.

@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
+ Coverage   55.17%   56.04%   +0.86%     
==========================================
  Files          97      101       +4     
  Lines        5870     6111     +241     
==========================================
+ Hits         3239     3425     +186     
- Misses       2631     2686      +55

Impacted Files	Coverage Δ
src/easydmp/plan/views/__init__.py	`32.44% <38.46%> (-0.20%)`	:arrow_down:
src/easydmp/plan/api/v1/views.py	`85.07% <75.00%> (-0.64%)`	:arrow_down:
src/easydmp/plan/api/v2/views.py	`85.71% <75.00%> (-0.65%)`	:arrow_down:
src/easydmp/site/urls.py	`68.75% <0.00%> (-1.84%)`	:arrow_down:
src/easydmp/site/api/v1/urls.py	`100.00% <0.00%> (ø)`
src/easydmp/site/api/v2/urls.py	`100.00% <0.00%> (ø)`
src/easydmp/eventlog/migrations/0001_initial.py	`100.00% <0.00%> (ø)`
...s/0001_squashed_0024_cleanup_plan_editor_groups.py	`100.00% <0.00%> (ø)`
...c/easydmp/plan/migrations/0008_convert_to_jsonb.py	`55.00% <0.00%> (ø)`
...sydmp/eventlog/migrations/0002_convert_to_jsonb.py	`73.33% <0.00%> (ø)`
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 25d9c74...07d9733. Read the comment docs.

vbhavdal commented 3 years ago

@hmpf Can you clarify what you mean by "add link to urls.py"? The view is already there.

hmpf commented 3 years ago

It is, I noticed when I switched url() over to path(). If you can add the endpoint to the API, I can look at adding a link to the web UI.

hmpf commented 3 years ago

A dropdown in a dropdown turns out not to be easy, so I just added another entry to the menu.

hmpf / easydmp

Plan export to PDF #164

Codecov Report