hmpf commented 3 years ago

This allows authenticating via drf token for any django view. Ugly, still sets session, while the point of token auth is no session. I don't think this is the correct way either but it beats the fugly direct hack on the generated plan views (#180).

codecov[bot] commented 3 years ago

Codecov Report

Merging #181 (3f8e6b1) into master (e4f1c66) will decrease coverage by 0.01%. The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #181      +/-   ##
==========================================
- Coverage   55.43%   55.42%   -0.02%     
==========================================
  Files         108      109       +1     
  Lines        5978     6008      +30     
==========================================
+ Hits         3314     3330      +16     
- Misses       2664     2678      +14

Impacted Files	Coverage Δ
src/easydmp/site/settings/base.py	`90.16% <ø> (ø)`
src/easydmp/auth/middleware.py	`71.42% <50.00%> (-28.58%)`	:arrow_down:
src/easydmp/auth/authentication.py	`100.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e4f1c66...3f8e6b1. Read the comment docs.

hmpf commented 3 years ago

This might be useful one day, but not today. Keeping the branch, and solving our immediate problem via #182 instead.

hmpf / easydmp

Authenticate via bearer token in Django proper #181

Codecov Report