search

hmpf / easydmp

MIT License
7 stars 2 forks source link

Outline model for repeatable sections #183

Closed vbhavdal closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #183 (41f8e40) into master (420dff0) will increase coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
+ Coverage   56.05%   56.07%   +0.02%     
==========================================
  Files          88       89       +1     
  Lines        6223     6226       +3     
==========================================
+ Hits         3488     3491       +3     
  Misses       2735     2735
Impacted Files Coverage Δ
...asydmp/plan/migrations/0009_repeatable_sections.py 100.00% <100.00%> (ø)
src/easydmp/plan/models.py 46.10% <100.00%> (-0.24%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 420dff0...41f8e40. Read the comment docs.

hmpf commented 3 years ago

The model changes themselves look fine.

But: should we put the actual answer in a json blob on the AnswerSet or on Answer? A task for another PR, but we do need to think hard and deep about it, data-migrations are such a hassle if we later change our minds.

hmpf commented 3 years ago

Superseded by the branch "storing-answers" merged in 56292e1d5d120e09fa603f68368c1f7f7a3d1001