search

hmpf / easydmp

MIT License
7 stars 2 forks source link

Delegate validation to AnswerSet. Support data on AnswerSet #185

Closed vbhavdal closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #185 (f7d45c8) into master (9451f43) will increase coverage by 0.91%. The diff coverage is 91.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
+ Coverage   55.75%   56.67%   +0.91%     
==========================================
  Files         112      113       +1     
  Lines        6191     6197       +6     
==========================================
+ Hits         3452     3512      +60     
+ Misses       2739     2685      -54
Impacted Files Coverage Δ
src/easydmp/plan/models.py 45.04% <88.46%> (+3.01%) :arrow_up:
src/easydmp/dmpt/models.py 54.78% <100.00%> (+2.67%) :arrow_up:
src/easydmp/plan/migrations/0008_answerset_data.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9451f43...f7d45c8. Read the comment docs.

vbhavdal commented 3 years ago

@hmpf Plan conversion is for a followup fix to this, since this doesn't yet change who owns the data dicts, only changes who does each part of validation.