search

hmpf / easydmp

MIT License
7 stars 2 forks source link

Fix bug when importing template that uses eestore #204

Closed hmpf closed 3 years ago

hmpf commented 3 years ago

There was some unnecessary validation in the ExportSerializer that prevented import. We need to export the primary keys of EEStoreMounts in order to map them to the new question ids, but validators are designed to check what is needed on implicit, automatic create and assumes the old question ids exist unchanged. We are validating only to check that the JSON is well-formed, not to directly write the JSON into the database, so a validator needed to be relaxed.

codecov[bot] commented 3 years ago

Codecov Report

Merging #204 (0afe868) into master (e816352) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #204   +/-   ##
=======================================
  Coverage   56.01%   56.01%           
=======================================
  Files          87       87           
  Lines        6218     6218           
=======================================
  Hits         3483     3483           
  Misses       2735     2735
Impacted Files Coverage Δ
src/easydmp/dmpt/export_template.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e816352...0afe868. Read the comment docs.