search

hmpf / easydmp

MIT License
7 stars 2 forks source link

Improve loading of setup data and helper data for development #205

Closed hmpf closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #205 (58aa1ae) into master (279d935) will increase coverage by 2.05%. The diff coverage is 74.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
+ Coverage   55.99%   58.05%   +2.05%     
==========================================
  Files          88       89       +1     
  Lines        6252     6291      +39     
==========================================
+ Hits         3501     3652     +151     
+ Misses       2751     2639     -112
Impacted Files Coverage Δ
src/easydmp/site/settings/base.py 90.16% <ø> (ø)
src/easydmp/auth/factories.py 74.35% <74.35%> (ø)
src/easydmp/dmpt/models.py 57.69% <0.00%> (+0.26%) :arrow_up:
src/easydmp/eventlog/models.py 82.66% <0.00%> (+1.33%) :arrow_up:
src/easydmp/auth/models.py 87.50% <0.00%> (+4.16%) :arrow_up:
src/easydmp/dmpt/admin.py 56.57% <0.00%> (+7.03%) :arrow_up:
src/easydmp/dmpt/import_template.py 76.31% <0.00%> (+44.21%) :arrow_up:
src/easydmp/eventlog/signals.py 87.50% <0.00%> (+50.00%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 279d935...58aa1ae. Read the comment docs.

hmpf commented 3 years ago

I'm not sure about naming and placement here: the "upgrade" app is for temporary management commands and utils, while setup (and also resetmigrationhistory are permanent, so I'm considering a new app. I'm not perfectly happy about the name of the "plan-templates" directory. Also, docs needs to be updated, and the existing devfixtures.json needs to go.