hmpf / easydmp

MIT License
7 stars 2 forks source link

Template designer improvements #210

Closed hmpf closed 3 years ago

hmpf commented 3 years ago

Closes #208

This will allow a Template Designer to create copies (new versions or private copies) of templates they already have access to.

Template import for Template Designers will be a separate PR.

hmpf commented 3 years ago

Currently, the copy isn't hooked up properly to the original import.

codecov[bot] commented 3 years ago

Codecov Report

Merging #210 (2831009) into master (8f8e80c) will increase coverage by 0.18%. The diff coverage is 85.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #210      +/-   ##
==========================================
+ Coverage   58.16%   58.35%   +0.18%     
==========================================
  Files          90       91       +1     
  Lines        6313     6320       +7     
==========================================
+ Hits         3672     3688      +16     
+ Misses       2641     2632       -9     
Impacted Files Coverage Δ
src/easydmp/lib/__init__.py 40.00% <ø> (+10.00%) :arrow_up:
src/easydmp/lib/admin.py 44.18% <50.00%> (+3.76%) :arrow_up:
src/easydmp/auth/utils.py 100.00% <100.00%> (ø)
src/easydmp/dmpt/admin.py 56.70% <100.00%> (+0.13%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8f8e80c...2831009. Read the comment docs.

hmpf commented 3 years ago

I'm splitting this into two PR's, one with copy/clone and one with import, because it would be smart to have better protection of published templates first, before willy-nilly import of templates is ok.

Also, import metadata isn't cloned at the moment, this is important for importing of published templates and making a new version locally.

hmpf commented 3 years ago

It is possible to generate cloning-information for a direct clone of an imported template after the fact, so this PR is ready for review/merge.