hmrc / claim-tax-refund-frontend

Apache License 2.0

1 stars 3 forks source link

Small Welsh update #583

Closed AIbrahimQA closed 1 year ago

AIbrahimQA commented 1 year ago

JIRA Story or Github Number - descriptive title

Bug fix / New feature (delete as appropriate)

Please include a summary / description of the change and which issue it fixes. Include any relevant user needs, context or links to other PRs related to this PR (eg. acceptance tests, environment config).

Checklist

[ ] I've made every effort to commit high quality, clean code and I have executed relevant static analyses to be sure
[ ] I've included appropriate tests with any code I've added (Unit, Integration, Acceptance etc.)
[ ] I've executed the acceptance test pack locally to ensure there are no functional regressions
[ ] I've added my code using logical, atomic commits, squashing as appropriate - including the JIRA issue number in the commit message
[ ] I've run a dependency check to ensure all dependencies are up to date

platops-pr-bot commented 1 year ago

SBT can be updated to 1.6.2 in project/build.properties
uk.gov.hmrc.sbt-auto-build can be updated to 3.8.0 in project/plugins.sbt
System property lookup can be removed in conf/application-json-logger.xml - Bootstrap's LoggerModule allows configuration of loggers without this. See README https://github.com/hmrc/bootstrap-play#version-5180
Config key play.ws.acceptAnyCertificate can be removed from conf/application.conf. This is obsolete and the behaviour is not recommended
There is a bobby error - see the pr builder for details