Closed AhmadZNaeem closed 1 year ago
SBT
can be updated to 1.7.2
in project/build.propertiesJava 8
, which will soon be removed. Please set JavaType.OPENJDK_JRE11
in build-jobsuk.gov.hmrc.mongo.hmrc-mongo-play-28
in build.sbt can be removed - its already provided by uk.gov.hmrc.mongo.hmrc-mongo-test-play-28
play.ws.acceptAnyCertificate
can be removed from conf/application.conf. This is obsolete and the behaviour is not recommendedplay.application.loader
can be removed from conf/application.conf. This is already provided by Bootstrapplay.http.requestHandler
can be removed from conf/application.conf. This is already provided by BootstrapExecutionContext.Implicits.global
from app/controllers/actions/DataRetrievalAction.scala - ExecutionContext
should be injected otherwise MDC logging will be brokenExecutionContext.Implicits.global
from app/connectors/DataCacheConnector.scala - ExecutionContext
should be injected otherwise MDC logging will be brokenExecutionContext.Implicits.global
from app/connectors/AddressLookupConnector.scala - ExecutionContext
should be injected otherwise MDC logging will be brokenExecutionContext.Implicits.global
from app/services/SubmissionService.scala - ExecutionContext
should be injected otherwise MDC logging will be brokenExecutionContext.Implicits.global
from app/repositories/SessionRepository.scala - ExecutionContext
should be injected otherwise MDC logging will be brokenuk.gov.hmrc.bootstrap-test-play-28
in build.sbt to provide recommended test dependencies. Use a variable to keep version in sync with bootstrap-playuk.gov.hmrc.mongo.hmrc-mongo-test-play-28
in build.sbt is not limited to test scope but pulls in test dependenciesuk.gov.hmrc.mongo.hmrc-mongo-play-28
in build.sbt can be removed - its already provided by uk.gov.hmrc.mongo.hmrc-mongo-test-play-28
play.ws.acceptAnyCertificate
can be removed from conf/application.conf. This is obsolete and the behaviour is not recommendedplay.application.loader
can be removed from conf/application.conf. This is already provided by Bootstrapplay.http.requestHandler
can be removed from conf/application.conf. This is already provided by BootstrapExecutionContext.Implicits.global
from app/controllers/actions/DataRetrievalAction.scala - ExecutionContext
should be injected otherwise MDC logging will be brokenExecutionContext.Implicits.global
from app/connectors/DataCacheConnector.scala - ExecutionContext
should be injected otherwise MDC logging will be brokenExecutionContext.Implicits.global
from app/connectors/AddressLookupConnector.scala - ExecutionContext
should be injected otherwise MDC logging will be brokenExecutionContext.Implicits.global
from app/services/SubmissionService.scala - ExecutionContext
should be injected otherwise MDC logging will be brokenExecutionContext.Implicits.global
from app/repositories/SessionRepository.scala - ExecutionContext
should be injected otherwise MDC logging will be brokenuk.gov.hmrc.bootstrap-test-play-28
in build.sbt to provide recommended test dependencies. Use a variable to keep version in sync with bootstrap-playuk.gov.hmrc.mongo.hmrc-mongo-test-play-28
in build.sbt is not limited to test scope but pulls in test dependenciesSBT
can be updated to 1.7.2
in project/build.propertiesJava 8
, which will soon be removed. Please set JavaType.OPENJDK_JRE11
in build-jobs
JIRA Story or Github Number - descriptive title
Bug fix / New feature (delete as appropriate)
Please include a summary / description of the change and which issue it fixes. Include any relevant user needs, context or links to other PRs related to this PR (eg. acceptance tests, environment config).
Checklist