hmrc / claim-tax-refund-frontend

Apache License 2.0

1 stars 3 forks source link

DL-14144 updating sca wrapper #597

Closed JoshMiernik closed 2 months ago

JoshMiernik commented 2 months ago

JIRA Story or Github Number - descriptive title

Bug fix / New feature (delete as appropriate)

Please include a summary / description of the change and which issue it fixes. Include any relevant user needs, context or links to other PRs related to this PR (eg. acceptance tests, environment config).

Checklist

[ ] I've made every effort to commit high quality, clean code and I have executed relevant static analyses to be sure
[ ] I've included appropriate tests with any code I've added (Unit, Integration, Acceptance etc.)
[ ] I've executed the acceptance test pack locally to ensure there are no functional regressions
[ ] I've added my code using logical, atomic commits, squashing as appropriate - including the JIRA issue number in the commit message
[ ] I've run a dependency check to ensure all dependencies are up to date

platops-pr-bot commented 2 months ago

oneForkedJvmPerTest can be removed from build.sbt - it's been provided and enabled by sbt-auto-build since 3.18.0
STDOUT_IGNORE_NETTY appender (and usage) can be removed from conf/logback.xml - Netty server is no longer used (Since Play 2.6.x)
ACCESS_LOG_FILE appender (and usage) can be removed from conf/logback.xml - it's never populated
File conf/application-json-logger.xml can be removed. Logging is provided by Bootstrap (since 8.6.0) and can be configured via application config alone - See confluence https://confluence.tools.tax.service.gov.uk/x/9oH1FQ

platops-pr-bot commented 2 months ago

~~oneForkedJvmPerTest can be removed from build.sbt - it's been provided and enabled by sbt-auto-build since 3.18.0~~
~~STDOUT_IGNORE_NETTY appender (and usage) can be removed from conf/logback.xml - Netty server is no longer used (Since Play 2.6.x)~~
~~ACCESS_LOG_FILE appender (and usage) can be removed from conf/logback.xml - it's never populated~~
File conf/application-json-logger.xml can be removed. Logging is provided by Bootstrap (since 8.6.0) and can be configured via application config alone - See confluence https://confluence.tools.tax.service.gov.uk/x/9oH1FQ