hmrc / design-patterns

Documenting HMRC design patterns
http://hmrc.github.io/assets-frontend/
MIT License
32 stars 4 forks source link

Form Valdiation - Sub level inputs #131

Closed Fenwick17 closed 7 years ago

Fenwick17 commented 7 years ago

Some forms have radio buttons when clicked display a sub level input. Currently there is not a pattern in place for error validation with these form types. A current implementation is: errorvalidation An alternative is: errorvalidation2 An alternative currently used design: errorvalidation3

adamliptrot-oc commented 7 years ago

@rpowis this is what I was talking about when I said about interaction between components (panel and error) in AF/Elements

rpowis commented 7 years ago

Thanks @Fenwick17. And I see what you mean now @adamliptrot-oc.

I wouldn't say that validation is a pattern or even a component in its own right. Validation should be a consideration of a pattern's implementation and most likely will be pattern specific. It looks like part of a payment pattern, but different to Make a payment?

gavinwye commented 7 years ago

This should be part of a validation pattern but each component should have validation thought about at a component level.