Open shabana-ali opened 2 years ago
Thanks for the detailed submission, appreciated. Shabana and I have discussed this.
Planned next steps: The DR team will put together a draft guidance page to be shared with Shabana and the relevant service teams for feedback and iteration. If positive we will then present to the working group for further feedback with an aim to publish.
The guidance at: https://design.tax.service.gov.uk/hmrc-design-patterns/eori-numbers/ contains the text: "If an invalid character is entered Say ‘EORI numbers can only have letters and numbers’."
Can I suggest we say something similar to that said elsewhere relating to unwanted characters?
Here are a selection:
Thanks, @terrysimpson99. This advice is already available in the guidance on recovering from validation errors, so I don't think we need to go into the same level of detail here. If this becomes a more widespread problem, we can consider how best to include or refer to that guidance in-page.
The reason I mention this is because it does appear to be a widespread problem. I see it frequently.
It's understandable: if the code is only letters and numbers, then it gets build to reject anything else. Users often don't report this type of error because they think it's their fault.
Not everybody knows about the guidance in 'recovering from validiation errors'. That's why it's repeated in other places where validation is mentioned. For example https://design-system.service.gov.uk/patterns/national-insurance-numbers/ includes the prompt: "ignore any unwanted characters before validating" There are other examples where something equivalent is said.
I was suggesting EORI does something similar.
Do XI EORI and GB EORI numbers sometimes/usually/always have identical digits?
Hi @terrysimpson99, I've added 'You should ignore any unwanted characters.' to the 'Asking for an EORI number' section, and also removed the invalid character error message as it's no longer needed.
EORI Number
Overview
During accessibility audits by the @hmrc/dias team, we are seeing variations in how EORI numbers are referenced, checked and asked for by service teams.
Establishing a pattern will ensure that:
We ask the HMRC design system working group to look into this taking into consideration what has already been done by service teams (see below for examples and recommendations we made with regards to accessibility issues identified) and develop the best practice.
Content designer @fred-jackson has put together hint text for EORI numbers from the UK.
Other components or patterns
There is existing content style guidance which is not always adhered by service teams. The EORI number pattern can reinforce or raise awareness of this:
EORI number would potentially follow the patterns:
Services with reference to EORI number
Check UK Destined status (within project UK Destined Validation service)
Example of a clear hint:
EU Subsidy Compliance
Checking EORI number (GitHub issue #3524):
The EORI number should be present in questions so that the information is available upfront for all users, i.e. a screen reader tabbing or using the form shortcuts may not be made aware of this information when needed. The page title may be kept as ‘Is this the EORI number you want to register?’ (TBD).
Current implementation:
Proposed solution:
Asking for EORI number (GitHub issue #3533):
When a user is asked to input an a EORI number, clear hint/error messages should be provided and accommodating validation to avoid confusion:
EORI Common Component
Prefix added (GitHub issue #3235):
Common Transit Convention (CTC) Arrivals - also known as NCTS
Variation of the hint text and error messages used (spaces and lowercase not accommodated) when asking for EORI number (GitHub issue #961):
CDS EORI
Variation of the hint text and error messages used (spaces and lowercase not accommodated) when asking for EORI number (GitHub issue #1286):
C-18 Disclose an Underpayment of Import Duties or VAT
Example of a variation in hint text and inappropriate text field length on a smaller viewport (GitHub issue #2056):
Check your guarantee balance
No hint provided and unclear error message when asking for EORI number (GitHub issue #3014, GitHub issue #3013):
Claim for reimbursement of import duties (C285 form replacement)
Hint copy for EORI numbers from any EU country (GitHub issue #2296):
Example of checking EORI number along with Name. This is the only instance where EORI number has been grouped with another key value (GitHub issue #2288):
Fulfilment House Due Diligence Scheme (FHDDS)
Check an EORI number
NVDA and TalkBack read "XI" as "11" (for reference only, no action required, GitHub issue #949)