search

hmrc / hmrc-frontend

Apache License 2.0
9 stars 19 forks source link

PLATUI-2106: fix timeout dialog bug #262

Closed oscarduignan closed 1 year ago

oscarduignan commented 1 year ago

Had to update puppeteer and tweak account-menu test as a result

I'm off the next 3 days but 🤞 these give a good test harness for fixing the bug

oscarduignan commented 1 year ago

tests failed in jenkins but pass locally, think maybe we need to wait for the element to be visible in the tests, a tomorrow problem

oscarduignan commented 1 year ago

tests failing on jenkins wasn't a race condition, it was because of hardcoded version number in the test fixtures

oscarduignan commented 1 year ago

have the acceptance tests but realised I haven't really explained why moving the bit of code that we did fixes the problem, so I've added some comments to the PR. The whole timeout dialog code could probably use some refactoring, but I'm not confident that we won't introduce bugs if we do any more now so kept it lightest touch possible