Plat UI 2847

[oscarduignan]

• [x] make sure I've got all the tudor crown stuff correctly 😵 (seems like it from the backstop tests)
• [x] flag with design resources and dias
  • should we be changing how the hmrc banner works to be in line govuk approach (no fallback ie8 image and path of svg all in one to avoid some a glitch they're documented in a comment)
  • new typographic scale coming in v6 that's available now to opt-into early to try out
  • for the header to work, I've had to put the extra things outside the header (which seems correct according to gds- but not sure how big of a change this will be for teams - something to talk about before merging)
• [x] does hmrc character count need any changes to support attributes / before and after html?
• [x] are there any header changes that need applying to our fork?
• [x] are there any footer changes that need applying to our fork?
• [x] rerun backstop tests and accept the changes
• [x] fix unit tests which svgs changing have broken
• [x] pull in latest npm audit fix and update changelog

Future stuff:

• [ ] refactor warnings to use govuk-font-size mixin
• [ ] there are some TODOs in hmrc header for possible improvements / bugs to fix in the future
• [ ] in play-frontend-hmrc we are reading "formGroup.classes" into "formGroupClasses" rather than an object, we now have extra params in a formGroup so we can deprecate formGroupClasses and add a formGroup param instead and use that if formGroupClasses is empty - I guess - this FormGroup param is shared amongst a few components

[oscarduignan]

bit of a last minute backtrack here, will let my commit describe what and why

https://github.com/hmrc/hmrc-frontend/pull/344/commits/82d690a58f63aedc796f003feeb43b5629a50b90

In trying to create an example of the issue that I changed the structure to fix, I realised that the issue [I was seeing] came not from a govuk change but from changing back to follow the govuk convention [and not applying our patch to it - moving the header to a wrapper and changing govuk-header to a div]. Because of that, even though I still think it would be good to match GOV.UK - it's not worth making that change as part of this - especially because we still have the language select and sign out links within the header which mean we wouldn't be able to get rid of our fork all together.