search

hmrc / platui-support

Apache License 2.0
0 stars 0 forks source link

UR Banner - add heading for navigation and identification #14

Closed adamliptrot-oc closed 2 years ago

adamliptrot-oc commented 2 years ago

Library or service name

https://github.com/hmrc/play-frontend-hmrc

Related component

UR Banner

Context

The UR banner has been flagged by DAC in a couple of audits as having what looks like a heading but is not a heading, prompting confusion at it not showing up in the heading list / be skipped over when navigating by heading.

https://github.com/hmrc/play-frontend-hmrc/blob/main/src/main/twirl/uk/gov/hmrc/hmrcfrontend/views/components/HmrcUserResearchBanner.scala.html#L26

Seems a fair issue when similar temporary banners have h2 to aid navigation.

The fix would be to add a heading (eg a h2 to stay with the cookie banner / error summary / notification banner pattern of things above the h1 getting an h2).

JoPintoPaul commented 2 years ago

Hi @adamliptrot-oc, thank you for raising this Github issue. PlatUI are now reviewing your issue. The next step will be for us to assign one of the following labels: accepted, cantfix, invalid, wontfix. We’ll update on this issue when a label is assigned.

ellamdav commented 2 years ago

Raised Jira ticket PLATUI-1721 to fix.

JoPintoPaul commented 2 years ago

@adamliptrot-oc This work has now been completed, and released in v3.18.0 of play-frontend-hmrc: https://github.com/hmrc/play-frontend-hmrc/releases/tag/v3.18.0