hmrc / platui-support

Apache License 2.0
0 stars 0 forks source link

UR Banner - make close link copy make sense when out of context #15

Closed adamliptrot-oc closed 2 years ago

adamliptrot-oc commented 2 years ago

Library or service name

https://github.com/hmrc/play-frontend-hmrc

Related component

UR Banner

Context

DAC have raised the issue of the close link a couple of times in audits.

As it only says “No thanks” it goes against the principle of being able to identify the link’s purpose when viewed out of context.

https://github.com/hmrc/play-frontend-hmrc/blob/main/src/main/twirl/uk/gov/hmrc/hmrcfrontend/views/components/HmrcUserResearchBanner.scala.html#L42

As such it should probably be something like

“No thanks, I don’t want to take part in user research”

(with the additional text visually hidden - I struggled to come up with a short way of saying it where all the text could be visible).

JoPintoPaul commented 2 years ago

Hi @adamliptrot-oc, thank you for raising this Github issue. PlatUI are now reviewing your issue. The next step will be for us to assign one of the following labels: accepted, cantfix, invalid, wontfix. We’ll update on this issue when a label is assigned.

terrysimpson99 commented 2 years ago

How about: “No, I do not want to take part in user research”

ellamdav commented 2 years ago

Thank you for raising this feature request. We’ve reviewed your suggestion within PlatUI, and we have opened a Jira Task ticket to work on this suggestion. You can track this ticket on our board via PLATUI-1723.

Thank you for this suggestion to improve our products.

oscarduignan commented 2 years ago

@adamliptrot-oc the change has been merged into hmrc-frontend from version 5.0.6 and play-frontend-hmrc from version 3.19.0

We'll make some posts to promote the releases in slack 👍