Version 1.0.0 release (PLATUI-1255 and PLATUI-1325)

hmrc / play-frontend-govuk

Apache License 2.0

5 stars 7 forks source link

Version 1.0.0 release (PLATUI-1255 and PLATUI-1325) #108

Closed matthewmascord closed 3 years ago

JoPintoPaul commented 3 years ago

Overall I think this PR looks good. However, for me, all the renamed views are showing up in Git as new files rather than renamed, which I assume would mean we lose the commit history of these files. Do we as a team think this would be a problem? Is there a way to force a rename rather than creation of new files?

matthewmascord commented 3 years ago

Resolved rename issues with Github.

oscarduignan commented 3 years ago

I've gone through it, looks good to me, but I'm going to go through it again in a bit before I tick it in case I missed anything because it's a big PR 👍

oscarduignan commented 3 years ago

run locally, and all looks good to me 👍