search

hmrc / sbt-settings

SBT plugin that provides common utility functions and configurations
Apache License 2.0
6 stars 10 forks source link

Refactor out test argument from default settings #8

Closed duncancrawford closed 8 years ago

duncancrawford commented 8 years ago

The test report argument is applicable to most but not all builds and therefore I have refactored the test argument out of the function defaultSettings(). The test argument defined in the function addTestReportOption() would need to be added to specific builds where applicable.

beyond-code-github commented 8 years ago

Hi, thanks for this. It seems sane. Have we done any analysis on which teams are using this option, and any comms put together regarding the change?

duncancrawford commented 8 years ago

All teams will currently get this by default and will give them there junit style of reporting on Jenkins.

No comms have been done but my intention was to communicate out once released. I will however add a comment in the readme and let you know.

Just to keep in mind no one tends to use this plugin directly as it gets pulled in by sbt -auto-build which I will update once this is released

Sent from iPhone

On 20 Oct 2016, at 09:57, Pete Smith notifications@github.com wrote:

Hi, thanks for this. It seems sane. Have we done any analysis on which teams are using this option, and any comms put together regarding the change?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

beyond-code-github commented 8 years ago

So this idea is that we will keep this enabled in sbt-auto-build so most people won't even notice?