hmrc / service-manager

A python tool to manage developing and testing with lots of microservices
Apache License 2.0
58 stars 37 forks source link

When running tests without mongo running tests fail #26

Closed vaughansharman closed 6 years ago

vaughansharman commented 9 years ago

This isn't such a huge problem but all you get is a stack dump which its immediately obvious (below)

Perhaps these tests that make use of mongo could dogfood sm to check the existence of mongo first as an actual test giving a better error message in the process...

Error Traceback (most recent call last): File "/Users/vsharman/repos/service-manager/test/tests.py", line 499, in test_offline smserverlogic.SmStartRequest(server, request, True, False).process_request() File "/Users/vsharman/repos/service-manager/servicemanager/server/smserverlogic.py", line 185, in process_request return self._stop_services_and_return_500("Unexpected exception: " + e.message) File "/Users/vsharman/repos/service-manager/servicemanager/server/smserverlogic.py", line 253, in _stop_services_and_return_500 errors = self._stop_services(drop_databases=True) File "/Users/vsharman/repos/service-manager/servicemanager/server/smserverlogic.py", line 130, in _stop_services self.context.drop_database_for_test() File "/Users/vsharman/repos/service-manager/servicemanager/smcontext.py", line 229, in drop_database_for_test self._drop_database(self.database_name_prefix) File "/Users/vsharman/repos/service-manager/servicemanager/smcontext.py", line 232, in _drop_database c = Connection() File "/Library/Python/2.7/site-packages/pymongo-2.6.3-py2.7-macosx-10.8-intel.egg/pymongo/connection.py", line 222, in init max_pool_size, document_class, tz_aware, _connect, **kwargs) File "/Library/Python/2.7/site-packages/pymongo-2.6.3-py2.7-macosx-10.8-intel.egg/pymongo/mongo_client.py", line 352, in init raise ConnectionFailure(str(e)) ConnectionFailure: could not connect to localhost:27017: [Errno 61] Connection refused

jakobgrunig commented 6 years ago

This is no longer the case