search

hmrc / service-manager

A python tool to manage developing and testing with lots of microservices
Apache License 2.0
58 stars 37 forks source link

Bug when starting a service with name that is the start of an already running service #29

Closed liquidarmour closed 9 years ago

liquidarmour commented 9 years ago

The latest release has introduced a problem that means a service will fail to start if there is a service whose name starts with the new services name.

EG. If you have 2 services GG and GG_STUBS and you declare them in a profile as 

GG_STUBS GG

then GG will fail to start.

Switching the order and both will start.

duncancrawford commented 9 years ago

@agilestevesmith, @charleskubicek & @HolyHaddock please can you look at this or get someone to look this today?

@liquidarmour

SiliconMeeple commented 9 years ago

Already looking at it.

duncancrawford commented 9 years ago

Cool, do we have a fix? (I am only the messenger btw)

vaughansharman commented 9 years ago

Im sure Mark is on this but a couple of suggestions in the meantime

You can manually install the previous version if this is affecting you: pip install servicemanager==0.0.23

Another suggestion is perhaps there is an issue (or an improvement you can make) with the regex in your services.json file...

SiliconMeeple commented 9 years ago

The patterns for JVM services are generated from the service name, which I think is something it would be good to keep.

My first stab at a fix turns out to have some issues.