Assets download fix for running from profiles

hmrc / service-manager

A python tool to manage developing and testing with lots of microservices

Apache License 2.0

58 stars 37 forks source link

Assets download fix for running from profiles #32

Closed rpowis closed 9 years ago

vaughansharman commented 9 years ago

I am a little concerned that this change is a little bit too HMRC specific. now that this code is open source we need to think about whether changes are valuable to all users... hardcoding a specific implementation of assets may regress the usefulness of the codebase as an open source project

Is it possible to handle assets in more generic way? Note: This may require some refactoring of the existing codebase...

rpowis commented 9 years ago

Valid points for refactoring but as we need to get this fix rolled out we'll make these changes in the next iteration.