search

hmrc / service-manager

A python tool to manage developing and testing with lots of microservices
Apache License 2.0
58 stars 37 forks source link

[SDT-133] remove reference to assets version Prod namespace #61

Closed feedmypixel closed 8 years ago

feedmypixel commented 8 years ago

There is work around standardising Service frontends assets.version Prod namespace. This work removes the Prod.*assets.*version="([0-9.]*) regex.

Related PR's: https://github.com/hmrc/play-ui/pull/61 https://github.com/hmrc/init-service/pull/13

Of Note

The current regex will continue to match assets.version within the Prod namespace. I don't feel this is the responsibility of service manager to enforce the assets.version config structure but I have raised an issue around this. #60

Also the tests around the Prod namesapce continue to pass due to the above issue.

rpowis commented 8 years ago

Fixes #60 by not caring where the assets version lives in the config. Agreed, it shouldn't enforce config structure. Now it just looks for all assets versions in a config file and starts them all. Shown in the tests