search

hmrc / service-manager

A python tool to manage developing and testing with lots of microservices
Apache License 2.0
58 stars 37 forks source link

Parallelising starting of services in smserver #86

Closed elabeca closed 6 years ago

elabeca commented 6 years ago

Our integration tests are failing in ci-dev due to the services taking too long to spin up. This fixes the issue and speeds up the process drastically.

jakobgrunig commented 6 years ago

Hi @elabeca

Thanks for your PR. I'm running the changes locally and the parallelism seems to be working. I can't say it is faster as my bottleneck is the network (10MBs), starting the services takes instead only a couple of seconds (8 services). Could you please be more specific than "speeds up the process drastically"?

The only issue I see is the download progress bar. By running multiple downloads in parallel, that is now totally messed up. Would it be possible for you to see if that can be fixed? Maybe with multiple progress bars one after the other updating at the same time?

Then we could think if it is possible to apply the same changes to sm as well.

Thank you.

jakobgrunig commented 6 years ago

I reviewed the PR a couple of times and found errors where separate processes remain hanging preventing smserver to shutdown. I discussed this with @elabeca and decided to close the PR for now