DL-14295: removed penaltiesEndpoints feature switch

hmrc / vat-api

Apache License 2.0

67 stars 18 forks source link

DL-14295: removed penaltiesEndpoints feature switch #1024

Closed Prem-Dasari closed 5 days ago

platops-pr-bot commented 6 days ago

SBT can be updated to 1.9.9 in project/build.properties
uk.gov.hmrc.sbt-auto-build can be updated to 3.23.0 in project/plugins.sbt
SbtAutoBuildPlugin can be removed from build.sbt - it's been automatically enabled since 3.0.0
STDOUT_IGNORE_NETTY appender (and usage) can be removed from conf/logback-test.xml - Netty server is no longer used (Since Play 2.6.x)
ACCESS_LOG_FILE appender (and usage) can be removed from conf/logback-test.xml - it's never populated

arunankannan commented 6 days ago

@Prem-Dasari i could see this flag being set as true in all env, please let us know why this is being removed? https://catalogue.tax.service.gov.uk/service/vat-api/config - feature-switch.penaltiesEndpoints.enabled 1) will there be a situation where we want to disable v1RoutesWithPenalties? 2) is v1Router deprecated?

Prem-Dasari commented 6 days ago

Hello @arunankannan We have removed this feature switch as per the ticket requirements DL-14295. This feature switch was introduced to dynamically toggle penalties-related functionality via v1RoutesWithPenalties. However, since the penalties endpoints are now fully live in all environments and there is no longer a need to toggle this functionality.

will there be a situation where we want to disable v1RoutesWithPenalties? -Currently, there is no identified requirements to disable v1RoutesWithPenalties because penalties functioality is a permanent feature of the service.

2.is v1Router deprecated? -Yes, v1Router is efficetively deprecated. Its purpose was to provide a fallback when penalties endpoints were disbaled via the feature switch. Since penalties endpoints are now always enabled, v1Router is no longer used and has been removed to maintain a clean codebase.