[DL-8546] - Create pager duties for when requests to DES fail

hmrc / vat-api

Apache License 2.0

66 stars 17 forks source link

[DL-8546] - Create pager duties for when requests to DES fail #922

Closed peckover closed 2 years ago

peckover commented 2 years ago

https://github.com/hmrc/alert-config/pull/2539 <---- DO NOT MERGE THIS UNTIL MONDAY

peckover commented 2 years ago

The logging part repeats quite a bit. could be refactored to another method perhaps. otherwise LGTM!

In the connectors? I did consider it but you still have to pass most of the parameters through and it looked messy. The logger comes from the StandardDesHttpParser so you'd have to pass that through too to avoid clashing. If you've got an idea feel free to push a commit