search

hms-dbmi-cellenics / issues

This repository is used to report and track issues
1 stars 0 forks source link

Remove duplicated code related to ScType and download rds worker tasks #15

Closed cosa65 closed 7 months ago

cosa65 commented 11 months ago

Background

Temporary duplicated functions were introduced with this PR. Specifically, functions parse_cellsets and add_clusters were duplicated and slightly modified to accomodate changes made in the python worker, creating a parse_cellsets_temp and a add_clusters_temp function. Changes in the python worker were made to modify the structure of the cellsets object that is sent to R (function get_cell_sets_dict_for_r in python/src/worker/helpers/cell_sets_dict.py).

These functions are used also by the ScType worker task.

Goals

Remove duplicated functions, keeping the temp functions as reference, making sure that everything works fine in the ScType and download processed rds worker tasks.

Modify the R tests accordingly if necessary.

kafkasl commented 10 months ago

is this merged? the link to the PR returns a 404.

cosa65 commented 8 months ago

https://github.com/hms-dbmi-cellenics/worker/pull/339