hms-dbmi-cellenics / issues

This repository is used to report and track issues
1 stars 0 forks source link

[Performance improvements] Pre-load marker genes on Data exploration #16

Closed kafkasl closed 5 months ago

kafkasl commented 10 months ago

Context

Concerning the slow load of genes in Data Exploration Context in this post by Vicky. tl;dr

Issues:

When we started doing downsampling in the worker for marker heatmap, we effectively stopped preloading marker genes for the gene list. That means that when you click them a new work request needs to go out and it's slow (5-8s).The goal of this ticket is to pre-load some of those genes to to make it more responsive. There are decisions to be made in terms of performance. The amount of marker genes grows with the dataset size (we compute 5 marker genes per sample) while the number of genes per page (of the gene list) does not. Ideally, we would like to preload all the marker genes. However, we don't want to do that if it means that big datasets become too slow.

Goal

  1. Add a mechanism in the UI to preload X genes which should be a single work request with the list of all genes to be preloaded.
  2. Initially try to preload all marker genes.
  3. Explore whether loading all marker genes is slow for very big experiments (large number of sample, not cells)
  4. If the performance is ok (make sure to check with Vicky) finish. Otherwise,
  5. Explore other heuristics like
    1. Setting a max amount of genes to be loaded
    2. Preloading only the first (or more) page of the gene list (for datasets which become slow)
    3. Or something else