hms-dbmi-cellenics / issues

This repository is used to report and track issues
1 stars 0 forks source link

[Performance improvements] Broken embeddings / marker heatmap pre-loading #24

Open kafkasl opened 10 months ago

kafkasl commented 10 months ago

Background

The way work requests Etag is computed in the UI / api should be the same. We use that to run the default embeddings, and marker heatmap after the data processing. That way when user goes to the data exploration they are already run and just need to be downloaded. Unfortunately that is broken as the test were updated separately and no longer match.

More details and link to involved files here:

https://this-is-biomage.slack.com/archives/C05END63C03/p1689586867051569

Goal

The goal is to decide the best solution for this.

According to Martin, fixing it for the heatmap (or embeddings? @cosa65 ) should be easy enough to do without changing so that's a good start.

However, this will be brittle and easy to break. Some ideas were floated around like moving the Etag calculation to the api (which has downsides as it requires many more UI-api requests).

Kristian-A commented 9 months ago

PRs: https://github.com/hms-dbmi-cellenics/ui/pull/896 https://github.com/hms-dbmi-cellenics/api/pull/483