hms-dbmi-cellenics / issues

This repository is used to report and track issues
1 stars 0 forks source link

Disable the commits from biomage-org/api in biomage-org/iac #53

Closed Kristian-A closed 5 months ago

Kristian-A commented 9 months ago

Background

Biomage's api commits the migrations into Biomage's iac. This results in different histories between hms-dbmi-cellenics and biomage-org. In addition the commits from biomage-org/api are not signed-off which breaks the DCO in the PR when it is opened against hms-dbmi-cellenics.

See this discussion for more context: https://this-is-biomage.slack.com/archives/C015CHSUDRU/p1694606730694849

Implementation

The commits appear every time biomage-org/api is synced or released. Disable the step which makes the commit so we rely only on the synchronization to update biomage-org/iac.

IMPORTANT

Due to the disabling of this action, biomage-org/iac and biomage-org/api would always need to be synched simultaneously. Potentially it is very dangerous if someone forgets to do this so Make sure this is well documented!!

kafkasl commented 9 months ago

https://github.com/hms-dbmi-cellenics/api/pull/484