search

hms-dbmi-cellenics / issues

This repository is used to report and track issues
1 stars 0 forks source link

[Bug] Absolute and Relative scaling buttons don't seem to be working in the dot plot #83

Closed vickymorrison closed 8 months ago

vickymorrison commented 11 months ago

Currently, the dot plot view does not change when 'absolute' or 'relative' scaling buttons are selected. It seems that the functionality is broken. A user reported this.

To do: Investigate if the buttons really are broken. If they are, fix them. Tell Vicky so she can email the user who reported this.

saracastel commented 10 months ago

I think the buttons are not broken. My understanding is that in some cases the difference between absolute and relative scale is not really visible. In the relative scale, the size of the dots is adjusted based on the max and min value. So in cases where the max value is close to 100%, the dot sizes on both scales appear similar, leading to a less noticeable difference. The distinction between the scales becomes more apparent, for example, in the Workshop dataset GSE183716, for gene CHAF1A, where the max value is 36.64%:

Image Image

StefanBabukov commented 10 months ago

I thought the same @saracastel when i was looking into it, but i wasnt sure if im correct.

vickymorrison commented 10 months ago

In that case @saracastel let's put this ticket to 'done' and I'll notify the user that the plot seems to be behaving as expected. Thanks for looking into it.

gerbeldo commented 10 months ago

yep, it seems to work correctly.