search

hms-dbmi / gehlenborglab-website

Code for Gehlenborg Lab website.
http://gehlenborglab.org
MIT License
8 stars 39 forks source link

John conroy/deploy with GitHub actions #273

Closed john-conroy closed 3 years ago

john-conroy commented 3 years ago

Since there isn't a dev deployment, we won't know this works until merged. Uses https://github.com/marketplace/actions/s3-sync.

keller-mark commented 3 years ago

Can we also run on pull requests, but stopping just before the deploy-to-S3 step, to catch any errors with the Jekyll build command

keller-mark commented 3 years ago

You may also be able to use the if syntax to prevent running the AWS steps on PRs https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idstepsif

john-conroy commented 3 years ago

Troubleshooting other issues now, thanks for the link! I'll re-request review once it's ready.

john-conroy commented 3 years ago

Successfully deployed to dev bucket.