hms-dbmi / gehlenborglab-website

Code for Gehlenborg Lab website.
http://gehlenborglab.org
MIT License
6 stars 37 forks source link

pinar lab member profile #312

Closed poe4 closed 2 years ago

manzt commented 2 years ago

Hey @poe4! I'm updating some information on the lab website and noticed this still hasn't been merged.

I see that the last commit includes firstname-lastname.md, which seems to be a template file that was committed by accident. Are you able to delete this file and push the latest changes? That way we won't have a "First Last" Student listed in the group members:

image

Otherwise the PR looks great! Preview:

image

Let me know if there is anything I can do to help!

ngehlenborg commented 2 years ago

The firstname-lastname.md should not be included. @poe4: can you remove that from the PR and resubmit?

poe4 commented 2 years ago

Hi @manzt, @ngehlenborg! I am so sorry for the error, and subsequent delay in resolving it. I just got home from traveling for a family emergency, and unfortunately did not have the machine with the erroneous file with me on the trip. I just deleted the file and pushed the updates--@manzt, could you please let me know if it didn't work? Thank you so much, and my apologies again for the holdup.

manzt commented 2 years ago

No problem at all! Just noticed it hadn't been merged – didn't mean to add additional stress to this challenging time.

The changes are appropriate, but the latest commit added another image file. There is now both:

The latter is the only one which ends up getting used in the site:

https://github.com/poe4/gehlenborglab-website/blob/adfa9420f120812a57f0c29597897496753edef9/_members/pinar-eser.md?plain=1#L5

We only need one file for the site. I'm guessing that you'd like to keep the aspectratio version? In that case, you can just delete the previous file (pinar-eser.png) and rename pinar-eser-aspectratio.png -> pinar-eser.png. Once you've made that change, please commit and push the latest, then we can merge.

poe4 commented 2 years ago

Thanks for catching this, Trevor! Better now?

manzt commented 2 years ago

Yup, looks good to me! @ngehlenborg

poe4 commented 2 years ago

Thanks so much!

ngehlenborg commented 2 years ago

Looking good!